Skip to content

fix button props typing for floating button #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2020
Merged

fix button props typing for floating button #1032

merged 1 commit into from
Nov 15, 2020

Conversation

Dor256
Copy link
Contributor

@Dor256 Dor256 commented Nov 12, 2020 •
edited by ethanshar
Loading

Description

Fix children typing for floating button props

Changelog

Fix typing for floating button props

@Dor256 Dor256 added the typescript typescript related issue label Nov 12, 2020
@Dor256 Dor256 requested a review from ethanshar November 12, 2020 13:41
@Dor256 Dor256 requested a review from M-i-k-e-l November 15, 2020 11:50
@M-i-k-e-l M-i-k-e-l merged commit 2d46a3a into master Nov 15, 2020
@Dor256 Dor256 deleted the floating-button-type-fix branch November 15, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

@ethanshar ethanshar Awaiting requested review from ethanshar

Assignees

@ethanshar ethanshar

@M-i-k-e-l M-i-k-e-l

Labels
typescript typescript related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dor256 @M-i-k-e-l @ethanshar