Skip to content

Calc modifiers in render methods so we can access context #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

Calc modifiers in render methods so we can access context #1035

merged 1 commit into from
Nov 16, 2020

Conversation

ethanshar
Copy link
Collaborator

Description

Stop using getDerivedStateFromProp in asBaseComponent to calculate modifiers.
Move modifiers calculation to the render method where we can access the component's context

Changelog

Fix issue with modifiers support based on context

@ethanshar ethanshar requested a review from M-i-k-e-l November 15, 2020 16:12
M-i-k-e-l
M-i-k-e-l reviewed Nov 15, 2020
View reviewed changes
@ethanshar ethanshar requested a review from M-i-k-e-l November 16, 2020 06:22
@M-i-k-e-l M-i-k-e-l merged commit b5d2fb5 into master Nov 16, 2020
@ethanshar ethanshar deleted the fix/asBaseComponent_contextSupport branch March 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l