Skip to content

Infra/unify docs #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 7, 2020
Merged

Infra/unify docs #1036

merged 15 commits into from
Dec 7, 2020

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented Nov 17, 2020

Description

  • Create an npm package for our gatsby docs files - uilib-docs
  • Export all relevant configurations like plugins and page creators

Changelog

Add a quick message for our users about this change

@ethanshar ethanshar marked this pull request as ready for review November 18, 2020 07:58
@ethanshar ethanshar requested a review from M-i-k-e-l November 18, 2020 07:59
@@ -4,7 +4,7 @@ module.exports = async ({graphql, boundActionCreators}) => {
const {createPage} = boundActionCreators;
const result = await graphql(`
{
allFile(filter: {sourceInstanceName: {eq: "markdown-pages"}}) {
allFile(filter: {sourceInstanceName: {eq: "markdown-pages"}, childMarkdownRemark: {frontmatter: {path: {ne: null}}}}) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure... :)
I guess we'll talk about it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the comment..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've said we'll discuss these PRs, so let's do that when you can.

@ethanshar ethanshar requested a review from M-i-k-e-l November 23, 2020 06:47
@M-i-k-e-l M-i-k-e-l mentioned this pull request Nov 24, 2020
@M-i-k-e-l M-i-k-e-l merged commit 0f768d4 into master Dec 7, 2020
@ethanshar ethanshar deleted the infra/unifyDocs branch March 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants