Modifiers - expose extractAccessibilityProps & extractComponentProps #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Nov 23, 2020
ethanshar
requested changes
Dec 1, 2020
| @@ -18,6 +18,7 @@ export { | |||
| } from './commons/new'; | |||
| export * as Incubator from './incubator'; | |||
| export * as Hooks from './hooks'; | |||
| export * as Modifiers from './commons/modifiers'; | |||
There was a problem hiding this comment.
I think this is incorrect.
This will export all Modifiers functions separately, while we want to export it as a whole class.
There was a problem hiding this comment.
You can see the usage in the private lib's PR, it is as follows:
import {Modifiers} from 'react-native-ui-lib';
{...Modifiers.extractAccessibilityProps(this.props)}
Is that not what you meant?
There was a problem hiding this comment.
yes.. it's actually correct.
Not sure why it look weird before :/
merging..
ethanshar
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifiers - expose extractAccessibilityProps & extractComponentProps
Changelog
Modifiers - expose extractAccessibilityProps & extractComponentProps