Skip to content

Image's tintColor with null value doesn't display on Android RN63 #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Image's tintColor with null value doesn't display on Android RN63 #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions src/components/button/__tests__/__snapshots__/index.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,9 +855,7 @@ exports[`Button container size should have no padding of button is an icon butto
source={14}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -1662,9 +1660,7 @@ exports[`Button icon should apply color on icon 1`] = `
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -1716,9 +1712,7 @@ exports[`Button icon should apply color on icon 2`] = `
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -1770,9 +1764,7 @@ exports[`Button icon should include custom iconStyle provided as a prop 1`] = `
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -1829,9 +1821,7 @@ exports[`Button icon should return icon style according to different variations
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -1883,9 +1873,7 @@ exports[`Button icon should return icon style according to different variations
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -1937,9 +1925,7 @@ exports[`Button icon should return icon style according to different variations
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down Expand Up @@ -2892,9 +2878,7 @@ exports[`Button labelColor should return undefined color if this is an icon butt
source={12}
style={
Array [
Object {
"tintColor": undefined,
},
undefined,
undefined,
undefined,
undefined,
Expand Down
2 changes: 1 addition & 1 deletion src/components/image/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class Image extends PureComponent<Props> {
// @ts-ignore
<ImageView
style={[
{tintColor},
tintColor && {tintColor},
shouldFlipRTL && styles.rtlFlipped,
cover && styles.coverImage,
this.isGif() && styles.gifImage,
Expand Down