Fix/picker get label #1059
Merged
Fix/picker get label #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Dec 6, 2020
Comment on lines
227
to
230
| getLabelValueText = () => { | ||
| const {value: propsValue} = this.props; | ||
| const {value: stateValue} = this.props; | ||
|
|
||
| if (this.shouldNotChangePickerLabelWhileSelecting()) { | ||
| return this.getLabel(propsValue); | ||
| } | ||
| return this.getLabel(stateValue); | ||
| const {value} = this.props; | ||
| return this.getLabel(value); | ||
| }; |
There was a problem hiding this comment.
I think that now getLabelValueText is redundant..
it's just a wrapper of this.getLabel.
Can we remove it?
There was a problem hiding this comment.
Right, It's just since there are value deconstruction that needs to be repeated for a few times in this class, maybe it's still valid?
There was a problem hiding this comment.
I think it was valid before when you had some logic there..
But now we use it only in one place and all it does it extract the value prop. Which seems a little redundant, no?
ethanshar
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed
getLabelproperty issue onmulti-selectmode.Changelog
Fixed
getLabelproperty issue onPicker'smulti-selectmode.