Disable panning in native picker dialogs #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendyEdri
reviewed
Dec 13, 2020
| @@ -83,7 +83,7 @@ class PickerDialog extends BaseComponent { | |||
| render() { | |||
| const dialogProps = extractComponentProps(Dialog, this.props); | |||
There was a problem hiding this comment.
this.props already contains panDirection as null, passed from NativePicker.
For some reason extractComponentProps not populating it when spreading passed props
There was a problem hiding this comment.
You are right, I missed that.
It should have already worked.
Checking...
mendyEdri
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable panning in native picker dialogs since they contains a wheel picker, scrolling thru the picker conflicts with the dialog panning. So it's best to just disable the panning in this case.
Changelog
Fix wheePicker swipe conflicts with dialog panning by disabling the dialog panning