Skip to content

add testID prop to Drawer & FloatingButton #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions generatedTypes/components/drawer/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,13 @@ interface Props {
* Custom value of any type to pass on to the component and receive back in the action callbacks
*/
customValue?: any;
/**
* Used as testing identifier
*/
testID?: string;
}
export declare type DrawerProps = Props;
export declare type DrawerItemProps = ItemProps;
/**
* @description: Drawer Component
* @important: If your app works with RNN, your screen must be wrapped
Expand Down
4 changes: 4 additions & 0 deletions generatedTypes/components/floatingButton/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ export interface FloatingButtonProps {
* Whether to show background overlay
*/
hideBackgroundOverlay?: boolean;
/**
* Used as testing identifier
*/
testID?: string;
}
declare const _default: React.ComponentClass<FloatingButtonProps & {
useCustomTheme?: boolean | undefined;
Expand Down
4 changes: 4 additions & 0 deletions src/components/drawer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ interface Props {
* Custom value of any type to pass on to the component and receive back in the action callbacks
*/
customValue?: any;
/**
* Used as testing identifier
*/
testID?: string;
}

export type DrawerProps = Props;
Expand Down
4 changes: 4 additions & 0 deletions src/components/floatingButton/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ export interface FloatingButtonProps {
* Whether to show background overlay
*/
hideBackgroundOverlay?: boolean;
/**
* Used as testing identifier
*/
testID?: string;
}

const SHOW_ANIMATION_DELAY = 350;
Expand Down