Feat/new wheel picker integration

[mendyEdri]

Description

Integrate the new WheelPicker into our Picker when passing useNativePicker prop.

WIP:

• Unwanted extra space in the WheelPicker when it's under the safeArea.
• FlatList's initialScrollIndex doesn't work, hacked with timer for now (could be a permanent fix).
• WheelPicker is not fully controlled; when passing a hard-coded data it still change when scrolling the WheelPicker,
  example: <WheelPicker selectedValue={‘Java’} /> when scrolling, it's not scrolling back to the 'Java' row.
• Implement and check behaviour on Android.
• Extract finding index to presenter/other type.
• add unit test for WheelPicker presenter.

Changelog

Integrate the new customizable WheelPicker into our Picker when passing useNativePicker prop.

[ethanshar]

• Unwanted extra space in the WheelPicker when it's under the safeArea.

See my comment in the code

• FlatList's initialScrollIndex doesn't work, hacked with timer for now (could be a permanent fix).

Instead of hacking with setTimeout. Try scrolling to initial index on FlatList's onLayout prop.

• WheelPicker is not fully controlled; when passing a hard-coded data it still change when scrolling the WheelPicker,
  example: <WheelPicker selectedValue={‘Java’} /> when scrolling, it's not scrolling back to the 'Java' row.

I don't think WheelPicker can ever be fully controlled because of the way users interact with it.
We can't have the wheel's value to wait for prop change, the interaction is too fast - so it must be uncontrolled in that way.
Having said that, the dialog picker can be controlled. cause the final value is determined only when pressing 'done'.

[mendyEdri]

the dialog picker can be

Agree, user interaction can constantly change the value.
though, I tried to mimic the current behaviour of WheelPicker, that was re-scrolling to value if it was controlled, so is it ok that the behaviour will differ?
2nd: when w'll have a few pickers, wi'll need a way to control the value.
(ex: min to max, max can't be lower then min)

[ethanshar]

the dialog picker can be

Agree, user interaction can constantly change the value.
though, I tried to mimic the current behaviour of WheelPicker, that was re-scrolling to value if it was controlled, so is it ok that the behaviour will differ?
2nd: when w'll have a few pickers, wi'll need a way to control the value.
(ex: min to max, max can't be lower then min)

I see what you mean..
I believe you want to treat the value prop as an initialValue and if the user change it in runtime it will reset to that value, right?

[mendyEdri]

and if the user change it in runtime it will reset to that value,

right. we probably going to need it

[ethanshar]

@mendyEdri
The reason this is pending is because we wanted to check it on a real one app version, right?
Did we tested on one app after the onChange fixes?

[ethanshar]

Approving, don't merge yet.
Let's figure how we want to rollout this feature carefully.

[mendyEdri]

@mendyEdri
The reason this is pending is because we wanted to check it on a real one app version, right?
Did we tested on one app after the onChange fixes?

@ethanshar, exactly. i've added in the jira-ticket the relevant one-app version with this fix :)

[mendyEdri]

@mendyEdri
The reason this is pending is because we wanted to check it on a real one app version, right?
Did we tested on one app after the onChange fixes?

@ethanshar, exactly. i've added in the jira-ticket the relevant one-app version with this fix :)

Approving, don't merge yet.
Let's figure how we want to rollout this feature carefully.

@ethanshar, We have UX approval for including it without haptic (yet).
Can I merge?