Fix/tab controller transition #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, how did you find this? Release notes? |
ethanshar
added a commit
that referenced
this pull request
Dec 22, 2020
* Move TabBarContext from js ro ts * Move TabPage from js to tsx * TabPage - move to typescript (fix typescript) * Move PageCarousel from js to tsx * PageCarousel - move to typescript (fix typescript) * Fix TabPage exception * Delete ReanimatedObject * Move TabBarItem from js to tsx * export TabPageProps * TabPage - fix description * Commit .d files * TabBarItem - move to typescript (fix typescript) * PageCarousel - move to typescript (fix typescript) - part 2 * Move TabBar from js to tsx * Move ScrollBarGradient from js to tsx * ScrollBarGradient add props and docs * Commit .d file * TabBar - move to typescript (fix typescript) * Move TabBarController from js to tsx * TabController - move to typescript (fix typescript) * Move TabControllerScreen to ts * Fix screen and some errors * Fix PR comments * Fix prop * Fix/tab controller transition (#1089) * Fix first tab item change doesn't repsond * Memoize renderCodeBlock in TabController components * Move TabBarController from index.tsx to TabBarController.tsx * Create TabControllerProps namespace * Create TabControllerProps namespace (fix screen) * Revert "Create TabControllerProps namespace (fix screen)" This reverts commit 0d3cff5. * Revert "Create TabControllerProps namespace" This reverts commit cd52f05. * Revert "Move TabBarController from index.tsx to TabBarController.tsx" This reverts commit 2b493ee. * Change interfaces names for TabController related classes Co-authored-by: Ethan Sharabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix animation issues in TabController, there are two commits here
Notice this PR branched from your PR (with all the TS changes, so there won't be any conflicts) - so merging it, will update your PR.
The First:
Fix the issue with the first time you press a tab bar item - there's no response
The second:
Fix a bigger issue.
Apparently they fixed something in [email protected] that expose a bug on our end.
It seems the
<Code>....</Code>blocks kept re-rendering while they should have been monetized.Re-redner the
Codeblock on state change cause the animation declarations to reset - which caused a huge problem.Changelog
Fix TabController animation issues with [email protected]