Typescript/tab controller move to function component #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
changed the title
…-component-2 * master: export Button enums fix typings Fix lint issues Fix Switch color based props to use ColorValue typing Fix manual placeholderTextColor typing for ChipsInput Fix manualy typing of ChipsInput for selectionColor prop fix @types/react-native version to 0.63.4 Fix rn63 typings (#1100) Revert "fix for tabbar types for scrollbar" fix for tabbar types for scrollbar ScrollBar - TS migration (#1078) TabBar refactor (#1076) Update reanimated and gesture-handler to their latest version cleanup Cards example screen upgraded expo demo app to expo v40 (#1096) Update RNN version # Conflicts: # src/components/tabController/TabBar.tsx
ethanshar
reviewed
Dec 30, 2020
There was a problem hiding this comment.
Looks Great!
Anyway, I wish we can maybe clean up some more the code in TabBar.
(Not saying it was super clean before..)
But see in one of my comments, I suggested using custom hooks for different parts of the code, no need to over do it, but it can make the TabBar's code more readable.
What do you think?
| } | ||
| }, []); | ||
|
|
||
| const [itemsWidths, setItemsWidths] = useState<number[]>([]); |
There was a problem hiding this comment.
consider moving some parts of the code to a separate custom hook (it does't have to be every part)
This will cleanup some of TabBar's code and create better separation.
For instance, maybe we can move the whole logic that calculates itemWidth and itemOffset to a separate hook.
There was a problem hiding this comment.
This is done in the second PR ✅
Simplify the ignore Co-authored-by: Ethan Sharabi <[email protected]>
ethanshar
approved these changes
Jan 3, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 3, 2021
…-logic * master: Fix lint error cleanup eslintrc file Infra/useDidUpdate (#1112) Support UI presets for Incubator.TextField and set a 'default' preset (#1111) Fix lint issues fix radioButton lint errors and generate types Fix/imageSource deprecation (#1115) Typescript/tab controller move to function component (#1098) Feat/radio button customize styling (#1092) bug fixes for TabBar refactor (#1106) Update ios target to 11 prettify file Fix icon size in badges example screen (#1104) icon prop - fix type to be both number and object. (#1086) enable eslint on both ts and js files (#1101) fix eslint (#1107) # Conflicts: # demo/src/screens/componentScreens/FaderScreen.tsx # src/components/fader/index.tsx # src/components/tabController/FadedScrollView.tsx # src/components/tabController/TabBar.tsx
M-i-k-e-l
deleted the
typescript/tab-controller-move-to-function-component-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabBarto function component.FadedScrollView(should we make this more generic, it has some RTL logic).Fader's RTL logic - please take a look at theFaderScreen, it has some logic, I'm not sure if that's ok.Changelog
Move TabBar to function component & add support for Fader in RTL