-
Notifications
You must be signed in to change notification settings - Fork 734
Use Colors.primary in components and change primary color to violet30 #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Some types have changes from
string
toany
(see the.d
files).
I've started by trying to solve the specific issue inthemeManager
(see below), but I don't think it's the way to go.
I've also tried to change the type incolors.ts
, but it did not work.
Do we want to ignore this or try to solve it?
Under theme = {
:
Colors.primary as string
backgroundColor: Colors.primary as string
In the getters:
get primaryColor(): string {
get CTABackgroundColor(): string {
- Some places that might have been missed (I was not sure if all of these should really be primary):
Screens: ChipsInputScreen ColorPickerScreen IncubatorTextFieldScreen LoadingScreen
PanDismissibleScreen PanResponderScreen PickerScreen (violet -> green) SliderScreen TouchableOpacityScreen HighlightOverlayViewScreen
Components: SelectableComponent ActionBar Hint WheelPicker PickerDialog (Android\iOS) TabBar+TabBarItem (TabController)
Docs: pages
If we only referring to the ThemeManager them object so I don't mind it too much. Yea, In some example screens I didn't change blue30 cause it wasn't really relevant. |
Components: Docs: |
SelectableComponent - We are removing this component in v6 I ignored it to avoid conflicts Docs: |
@ethanshar How can I override primary color for WheelPicker? |
Hi @matextrem, |
Hey @M-i-k-e-l, thanks for your quick reply! Sorry for the confusion, I was talking about https://wix.github.io/react-native-ui-lib/docs/components/form/Picker/Picker I wanted to know how to change that violet color. |
Using the following should still work:
Let me know if that did the trick. |
@M-i-k-e-l That did the trick! Thanks you so much for the help. |
Description
Use Colors.primary in all of our components instead of Colors.blue30
Change primary to violet30
(This change might affect private lib snapshots)
Changelog
Update our default primary color to Colors.violet30