fix prop types for ChipsInput props #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
requested changes
Jan 19, 2021
typings/components/ChipsInput.d.ts
Outdated
| @@ -1,7 +1,9 @@ | |||
| import { TypographyModifiers } from 'generatedTypes'; | |||
There was a problem hiding this comment.
Looks like you've left this be mistake
typings/components/ChipsInput.d.ts
Outdated
| import {ReactElement} from 'react'; | ||
| import {StyleProp, TextStyle, ViewStyle, AccessibilityProps, ColorValue} from 'react-native'; | ||
| import {BaseComponent} from '../commons'; | ||
| import {AccessibilityProps} from '../modifiers'; | ||
| import { TextInputProps } from './Inputs'; |
There was a problem hiding this comment.
Shouldn't this be TextFieldProps?
There was a problem hiding this comment.
Hmm, I don't really know as I've only seen this used in our module as TextInput you know the use cases better than me :)
There was a problem hiding this comment.
you know the use cases better than me :)
Not really, it's just using a TextField with {...others} :)
Dor256
force-pushed
the
chips-input-prop-types
branch
2 times, most recently
from
40d8cb4 to
b2a3f29
Compare
Dor256
force-pushed
the
chips-input-prop-types
branch
from
b2a3f29 to
68741fc
Compare
M-i-k-e-l
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix typing of
ChipsInputPropsby extendingTextInputPropsChangelog
Fix
ChipsInputprop typings