Feat/support customElement in Badge #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 26, 2021
src/components/badge/index.tsx
Outdated
Comment on lines
248
to
249
| !customElement && | ||
| icon && ( |
There was a problem hiding this comment.
I don't think the icon should depend on customElement..
The user should decide what they want to pass.
src/components/badge/index.tsx
Outdated
| @@ -230,38 +236,35 @@ class Badge extends PureComponent<BadgeProps> { | |||
| } | |||
| } | |||
|
|
|||
| renderCustomElement() { | |||
| const {customElement} = this.props; | |||
| return customElement && <View>{customElement}</View>; | |||
There was a problem hiding this comment.
Is wrapping the customElement with a View necessary?
ethanshar
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support passing custom element to Badge component.
Add examples to the Badge example screen.
Changelog
Support passing custom element to Badge component.