Infra/expo app fixes #1166

ethanshar · 2021-01-30T08:46:09Z

Description

Fixes for #1150

Update UI of our expo app
Use SectionList instead of ScrollView and fix flex issue of the whole screen
Register missing ChipScreen

Changelog

Expo App fixes and improvements

brentvatne · 2021-02-02T23:38:22Z

small suggestion for the Snack link on the website (not sure where the source for this is) -- you can add query params so it doesn't show the web version, for example:

https://snack.expo.io/@ethanshar/rnuilib_snack?platform=ios&supportedPlatforms=ios,android

one other thing you might want to consider - you can also store the source for your app in a file and pass in the dependencies as query params, eg:

https://snack.expo.io/?platform=android&name=Getting%20started%20%7C%20React%20Navigation&dependencies=%40expo%2Fvector-icons%40*%2C%40react-native-community%2Fmasked-view%40*%2C%40react-navigation%2Fbottom-tabs%40%5E5.8.0%2C%40react-navigation%2Fdrawer%40%5E5.9.0%2C%40react-navigation%2Fmaterial-bottom-tabs%40%5E5.2.16%2C%40react-navigation%2Fmaterial-top-tabs%40%5E5.2.16%2C%40react-navigation%2Fnative%40%5E5.7.3%2C%40react-navigation%2Fstack%40%5E5.9.0%2Creact-native-paper%40%5E4.0.1%2Creact-native-reanimated%40*%2Creact-native-safe-area-context%40*%2Creact-native-gesture-handler%40*%2Creact-native-screens%40*%2Creact-native-tab-view%40%5E2.15.1&hideQueryParams=true&sourceUrl=https%3A%2F%2Freactnavigation.org%2Fexamples%2F5.x%2Ffull-screen-modal.js

decoded this looks like:

platform=android&name=Getting started | React Navigation&dependencies=@expo/vector-icons@*,@react-native-community/masked-view@*,@react-navigation/bottom-tabs@^5.8.0,@react-navigation/drawer@^5.9.0,@react-navigation/material-bottom-tabs@^5.2.16,@react-navigation/material-top-tabs@^5.2.16,@react-navigation/native@^5.7.3,@react-navigation/stack@^5.9.0,react-native-paper@^4.0.1,react-native-reanimated@*,react-native-safe-area-context@*,react-native-gesture-handler@*,react-native-screens@*,react-native-tab-view@^2.15.1&hideQueryParams=true&sourceUrl=https://reactnavigation.org/examples/5.x/full-screen-modal.js"

(this is an example from https://reactnavigation.org/docs/modal#creating-a-modal-stack)

ethanshar · 2021-02-15T05:25:05Z

@brentvatne
Amazing thanks!

expoDemo/.gitignore

mendyEdri · 2021-02-15T07:36:53Z

expoDemo/MainScreen.js

 export default function MainScreen({navigation}) {
  const [searchText, setSearchText] = React.useState('');

+  const renderSectionHeader = useCallback(({section}) => {
+    if (!_.find(section.data, screen => _.includes(screen.title.toLowerCase(), searchText.toLowerCase()))) {


maybe extract the search logic _includes(screen... to avoid duplication with renderItem

Fixed and improved search using fuzzy search

mendyEdri · 2021-02-15T08:16:28Z

expoDemo/MainScreen.js

+        activeBackgroundColor={Colors.violet80}
+        onPress={() => {
+          // convert "unicorn.components.ActionBarScreen" -> "ActionBar"
+          const screenId = _.chain(item.screen).split('.').last().replace('Screen', '').value();


Maybe extract with useCallback

mendyEdri

Just small comments

Co-authored-by: Mendy Edri <[email protected]>

* master: (30 commits) Button - refactor into smaller files (#1168) replace @react-native-community/picker with @react-native-picker/picker (#1063) Update generate types fix: catch undefined StatusBarManager (#1189) prop value shape deprecation lint rule (#1094) Infra/expo app fixes (#1166) Safe require blur-view dependency in Card (#1179) Update our stars count Update expo snack link with only supported platforms Export TabBarProps and fix BadgeScreen typescript errors Disable flipper Avoid passing overlayContent in CardSecion (#1187) Fix Carousel typings updating published version no-direct-import eslint rule - adding `applyAutofix` flag (#1183) Feat/image demo broken (#1173) Remove addItems from screen with fewItems Add vertical scroll to Carousel component (#1175) Fix Carousel gif Update Carousel gifs ... # Conflicts: # demo/src/screens/componentScreens/BadgesScreen.tsx # generatedTypes/components/button/index.d.ts # markdowns/getting-started/setup.md # src/components/button/index.tsx # src/components/card/CardSection.tsx # src/components/card/index.tsx # src/components/loaderScreen/index.js # src/components/modal/index.tsx # typings/components/Toast.d.ts # uilib-docs/src/templates/markdown.scss

* Add customLoader and remove animatable (#1152) * Add customLoader and remove animatable * remove redundent view Co-authored-by: Ethan Sharabi <[email protected]> * Fix/responsive docs pages (#1174) * Support showing navbar in mobile * More minor responsive fixes * Fix margin top in navbar on mobile * Fix/tab controller center android with rtl (#1178) * Update generate types * Update uilib-docs version to 1.0.11 * Fix order of markdown pages in docs site * Fix issue with duplicate props appearing in docs site * Fix issue with Carousel props not being included in docs * Update PageControl docs with a gif * Fix and improve search using fuzzysearch * Update Carousel gifs * Fix Carousel gif * Add vertical scroll to Carousel component (#1175) * Add vertical scroll to Carousel component * cr fixes Co-authored-by: Ethan Sharabi <[email protected]> * Remove addItems from screen with fewItems * Feat/image demo broken (#1173) * no-direct-import eslint rule - adding `applyAutofix` flag (#1183) * no-direct-import eslint rule - adding `applyAutofix` flag to control autofix option * bumping version to 1.1.00 * version number fix * Update eslint-rules/package.json Co-authored-by: Ethan Sharabi <[email protected]> Co-authored-by: Ethan Sharabi <[email protected]> * updating published version * Fix Carousel typings * Avoid passing overlayContent in CardSecion (#1187) * Disable flipper * Export TabBarProps and fix BadgeScreen typescript errors * Update expo snack link with only supported platforms * Update our stars count * Safe require blur-view dependency in Card (#1179) * safe require blur-view dependency in card and warn user if missing * Add optional require for blur-view package in Modal component * Update generate types * Infra/expo app fixes (#1166) * Load assets for demo app * expo settings stuff * Update UI for main screen * use useCallback for renderItem and renderSectionHeader * register ChipScreen so it will be accessible in expo demo app * Update README * remove .expo files from git * Update .gitignore to exclude .expo files * Use Incubator.TextField * Update our expo demo icon with the new one * Update expoDemo/.gitignore Co-authored-by: Mendy Edri <[email protected]> * code review fixes and search improvements * refactor item onPress and use useCallback Co-authored-by: Mendy Edri <[email protected]> * prop value shape deprecation lint rule (#1094) * set new lint rule for prop value * fix schema * add cases to prop-value-shape lint rule * refactor propShapeValueDeprecation * Adding two (failing) tests * Fix test and add two more big tests * More tests * add getComponentName to utils * Renaming * update message when there's no fix * fix deprecation message * update version Co-authored-by: Miki Leib <[email protected]> * fix: catch undefined StatusBarManager (#1189) * Update generate types * replace @react-native-community/picker with @react-native-picker/picker (#1063) * replace @react-native-community/picker with @react-native-picker/picker * Safely require Picker package * Use optional require only for iOS * Update expo dependncy to use @react-native-picker/picker * Button - refactor into smaller files (#1168) * Button - refactor into smaller files (reanimated 2 part 1) * Oops Co-authored-by: Ethan Sharabi <[email protected]> Co-authored-by: Lidor Dafna <[email protected]> Co-authored-by: Ethan Sharabi <[email protected]> Co-authored-by: Daniel Kochavi <[email protected]> Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Mendy Edri <[email protected]> Co-authored-by: Julian Hundeloh <[email protected]>

* master: (77 commits) Button - refactor into smaller files (#1168) replace @react-native-community/picker with @react-native-picker/picker (#1063) Update generate types fix: catch undefined StatusBarManager (#1189) prop value shape deprecation lint rule (#1094) Infra/expo app fixes (#1166) Safe require blur-view dependency in Card (#1179) Update our stars count Update expo snack link with only supported platforms Export TabBarProps and fix BadgeScreen typescript errors Disable flipper Avoid passing overlayContent in CardSecion (#1187) Fix Carousel typings updating published version no-direct-import eslint rule - adding `applyAutofix` flag (#1183) Feat/image demo broken (#1173) Remove addItems from screen with fewItems Add vertical scroll to Carousel component (#1175) Fix Carousel gif Update Carousel gifs ... # Conflicts: # eslint-rules/lib/rules/typography-deprecation.js # eslint-rules/package.json # eslint-rules/tests/lib/rules/typography-deprecation.js # eslint-rules/tests/typography_deprecation.json

ethanshar added 6 commits January 30, 2021 10:23

Load assets for demo app

e6c654d

expo settings stuff

0dddb68

Update UI for main screen

7b368ec

use useCallback for renderItem and renderSectionHeader

e8f3ed5

Merge branch 'master' into infra/expoAppFixes

f149c83

register ChipScreen so it will be accessible in expo demo app

c0348bb

ethanshar requested a review from mendyEdri January 31, 2021 09:41

ethanshar assigned mendyEdri Jan 31, 2021

Merge branch 'master' into infra/expoAppFixes

f5cc646

ethanshar added 6 commits February 15, 2021 07:42

Merge branch 'master' into infra/expoAppFixes

1fa9580

Update README

1e07101

remove .expo files from git

be38517

Update .gitignore to exclude .expo files

ce4ba26

Use Incubator.TextField

640334a

Update our expo demo icon with the new one

609e1c3

mendyEdri reviewed Feb 15, 2021

View reviewed changes

expoDemo/.gitignore Outdated Show resolved Hide resolved

mendyEdri reviewed Feb 15, 2021

View reviewed changes

mendyEdri approved these changes Feb 15, 2021

View reviewed changes

ethanshar and others added 3 commits February 15, 2021 10:17

Update expoDemo/.gitignore

c3c3390

Co-authored-by: Mendy Edri <[email protected]>

code review fixes and search improvements

b37cc2c

refactor item onPress and use useCallback

8e240da

ethanshar requested a review from mendyEdri February 15, 2021 08:47

mendyEdri approved these changes Feb 15, 2021

View reviewed changes

mendyEdri merged commit 79e8e37 into master Feb 15, 2021

ethanshar deleted the infra/expoAppFixes branch July 26, 2021 09:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Infra/expo app fixes #1166

Infra/expo app fixes #1166

Uh oh!

ethanshar commented Jan 30, 2021

Uh oh!

brentvatne commented Feb 2, 2021 •

edited

Loading

Uh oh!

ethanshar commented Feb 15, 2021

Uh oh!

Uh oh!

mendyEdri Feb 15, 2021 •

edited

Loading

Uh oh!

ethanshar Feb 15, 2021

Uh oh!

mendyEdri Feb 15, 2021

Uh oh!

ethanshar Feb 15, 2021

Uh oh!

mendyEdri left a comment

Uh oh!

Uh oh!

Infra/expo app fixes #1166

Infra/expo app fixes #1166

Uh oh!

Conversation

ethanshar commented Jan 30, 2021

Description

Changelog

Uh oh!

brentvatne commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ethanshar commented Feb 15, 2021

Uh oh!

Uh oh!

mendyEdri Feb 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ethanshar Feb 15, 2021

Choose a reason for hiding this comment

Uh oh!

mendyEdri Feb 15, 2021

Choose a reason for hiding this comment

Uh oh!

ethanshar Feb 15, 2021

Choose a reason for hiding this comment

Uh oh!

mendyEdri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brentvatne commented Feb 2, 2021 •

edited

Loading

mendyEdri Feb 15, 2021 •

edited

Loading