DialogDismissibleView - refactor to function #1170
Conversation
There was a problem hiding this comment.
@M-i-k-e-l
I think there's is a misusage of the useCallback hook.
I wrote a few comments, but overall I think it most cases you don't to use useCallback
The main purpose for using it for a function is when you want to pass a callback as a prop for another component.
And since here it's not the case, most function can just be a regular functions.
| const prevSwipeDirections = useRef<PanDirectionsProps>(); | ||
| const visible = useRef<boolean>(Boolean(propsVisible)); | ||
|
|
||
| const getHiddenLocation = useCallback((left: number, top: number): LocationProps => { |
There was a problem hiding this comment.
Why are you using useCallback here? You're not passing it as a prop
There was a problem hiding this comment.
But it's being used in onLayout which is passed as a prop.
There was a problem hiding this comment.
Then I think it's enough that only onLayout will be wrapped with useCallback, no?
getHiddenLocation can be a pure function that has no dependencies
There was a problem hiding this comment.
Are we leaving this as is (following our meeting today)?
| private thresholdX = 0; | ||
| private thresholdY = 0; | ||
| private ref = React.createRef<any>(); | ||
| const animateTo = useCallback((toValue: number, animationEndCallback?: Animated.EndCallback) => { |
There was a problem hiding this comment.
No need for useCallback
There was a problem hiding this comment.
Used in onLayout as well.
|
|
||
| constructor(props: Props) { | ||
| super(props); | ||
| const isSwiping = useCallback((): boolean => { |
There was a problem hiding this comment.
Also here.. useCallback seem redundant.
Even the function content only use reference values
There was a problem hiding this comment.
Also, verify you really need to declare a return type.
Typescript usually handles it automaticaly
There was a problem hiding this comment.
isSwiping is used in onDrag which is used in useEffect.
Removed a couple of return values.
Description
DialogDismissibleView - refactor to function
Changelog
DialogDismissibleView - refactor to function