Changed useSafeArea default value
#1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Feb 3, 2021
|
@mendyEdri Please check why the build is faling |
Inbal-Tish
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CustomKeyboard had a fix some time ago, to remove the safe area (annoying grey part at the bottom).
In order to avoid migration back at the time, I've set
useSafeAreadefault value totruealthough other UILib components set it tofalseby default.In this PR it fixed, and moved to be
falseby defaultChangelog
When using
KeyboardAccessoryView,useSafeAreadefault value has changed fromtruetofalse, to match all other UILib's api that by default it isfalse.