TabController - remove from incubator and remove support for children in TabBar #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Feb 10, 2021
| @@ -344,7 +344,7 @@ declare const _default: React.ComponentClass<ViewProps & TouchableOpacityProps & | |||
| /** | |||
| * the badge size (default, small) | |||
| */ | |||
| size: number; | |||
| size?: number | undefined; | |||
There was a problem hiding this comment.
Why do you need to specify undefined type for an optional prop?
There was a problem hiding this comment.
I don't, this is the automatically generated .d.ts file (when running npm run build:dev).
Inbal-Tish
reviewed
Feb 10, 2021
| } | ||
|
|
||
| if ((propsItems || children.current) && !contextItems) { | ||
| if (propsItems && !contextItems) { | ||
| _registerTabItems(); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
Why no dependencies here, like 'items'? Won't it cause unnecessary updates?
There was a problem hiding this comment.
On the contrary, no dependencies means no re-renders (this is similar to componentDidMount).
Inbal-Tish
approved these changes
Feb 10, 2021
M-i-k-e-l
deleted the
v6-tab-controller-remove-from-incubator-and-children
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabController - remove from incubator and remove support for children in TabBar
Changelog
TabController - remove from incubator and remove support for children in TabBar