Update Incubator.TextField Code Example link url to correct path #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Feb 17, 2021
|
@fvonhoven amazing, thanks! |
ethanshar
reviewed
Feb 17, 2021
src/incubator/TextField/index.tsx
Outdated
| @@ -200,7 +200,7 @@ const TextField = (props: InternalTextFieldProps) => { | |||
| retainSpace | |||
| /> | |||
| )} | |||
| {showCharCounter && <CharCounter maxLength={others.maxLength} charCounterStyle={charCounterStyle}/>} | |||
| {showCharCounter && <CharCounter maxLength={others.maxLength} charCounterStyle={charCounterStyle} />} | |||
There was a problem hiding this comment.
please remove space, it cause a lint error
Suggested change
| {showCharCounter && <CharCounter maxLength={others.maxLength} charCounterStyle={charCounterStyle} />} | |
| {showCharCounter && <CharCounter maxLength={others.maxLength} charCounterStyle={charCounterStyle}/>} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Code Example" link at https://wix.github.io/react-native-ui-lib/docs/Incubator.TextField/ went to an outdated folder in the repo. Updated link to use the correct path to the component in the repo.
Changelog
Update docs for Incubator.TextFIeld link to example code so it opens the correct url and doesn't 404.