Skip to content

Feat/optional dependencies #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions generatedTypes/optionalDependencies.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
declare let BlurViewPackage: any;
declare let DateTimePickerPackage: any;
declare let NetInfoPackage: any;
declare let PickerPackage: any, CommunityPickerPackage: any;
export { BlurViewPackage, DateTimePickerPackage, NetInfoPackage, PickerPackage, CommunityPickerPackage };
2 changes: 2 additions & 0 deletions generatedTypes/optionalDependencies/BlurViewPackage.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declare let BlurViewPackage: any;
export default BlurViewPackage;
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declare let DateTimePickerPackage: any;
export default DateTimePickerPackage;
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declare let GestureHandlerPackage: any;
export default GestureHandlerPackage;
2 changes: 2 additions & 0 deletions generatedTypes/optionalDependencies/NetInfoPackage.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declare let NetInfoPackage: any;
export default NetInfoPackage;
2 changes: 2 additions & 0 deletions generatedTypes/optionalDependencies/PickerPackage.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declare let PickerPackage: any, CommunityPickerPackage: any;
export { PickerPackage, CommunityPickerPackage };
4 changes: 4 additions & 0 deletions generatedTypes/optionalDependencies/index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export { default as DateTimePickerPackage } from './DateTimePickerPackage';
export { default as BlurViewPackage } from './BlurViewPackage';
export { default as NetInfoPackage } from './NetInfoPackage';
export { PickerPackage, CommunityPickerPackage } from './PickerPackage';
20 changes: 8 additions & 12 deletions lib/components/WheelPicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,14 @@ import WheelPickerItem from './WheelPickerItem';
import {Constants} from '../../../src/helpers';
import {Typography, Colors} from '../../../src/style';

/* Safely require picker component */
let Picker = () => null;
if (Constants.isIOS) {
try {
Picker = require('@react-native-picker/picker').Picker; // New package
} catch (e) {
try {
Picker = require('@react-native-community/picker').Picker; // Deprecated package
console.warn(`RNUILib Picker will soon migrate to use "@react-native-picker/picker" package instead of '@react-native-community/picker'`);
} catch (e) {
console.error(`RNUILib Picker requires installing "@react-native-picker/picker" dependency`);
}
import {PickerPackage, CommunityPickerPackage} from '../../../src/optionalDependencies';
const Picker = PickerPackage?.Picker || CommunityPickerPackage?.Picker || (() => null);

if (!PickerPackage) {
if (CommunityPickerPackage) {
console.warn(`RNUILib Picker will soon migrate to use "@react-native-picker/picker" package instead of '@react-native-community/picker'`);
} else {
console.error(`RNUILib Picker requires installing "@react-native-picker/picker" dependency`);
}
}

Expand Down
7 changes: 3 additions & 4 deletions src/components/card/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@ import TouchableOpacity, {TouchableOpacityProps} from '../touchableOpacity';
import Image from '../image';
import CardImage from './CardImage';
import CardSection, {CardSectionProps} from './CardSection';
import {BlurViewPackage} from '../../optionalDependencies';
// @ts-ignore
import Assets from '../../assets';
import CardContext from './CardContext';
import * as CardPresenter from './CardPresenter';

let BlurView: any;
try {
BlurView = require('@react-native-community/blur').BlurView;
} catch (error) {} // warning in ctor, depends if user pass enableBlur
const BlurView = BlurViewPackage?.BlurView;


const DEFAULT_BORDER_RADIUS = BorderRadiuses.br40;
const DEFAULT_SELECTION_PROPS = {
Expand Down
13 changes: 9 additions & 4 deletions src/components/connectionStatusBar/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import PropTypes from 'prop-types';
import _ from 'lodash';
import {StyleSheet, Text} from 'react-native';
import NetInfo from '@react-native-community/netinfo';
import {NetInfoPackage as NetInfo} from '../../optionalDependencies';
import {Constants} from '../../helpers';
import {PureBaseComponent} from '../../commons';
import {Colors, Typography} from '../../style';
Expand Down Expand Up @@ -59,15 +59,20 @@ export default class ConnectionStatusBar extends PureBaseComponent {
isConnected: true,
isCancelled: false
};
this.getInitialConnectionState();

if (NetInfo) {
this.getInitialConnectionState();
} else {
console.error(`RNUILib ConnectionStatusBar component requires installing "@react-native-community/netinfo" dependency`);
}
}

generateStyles() {
this.styles = createStyles();
}

componentDidMount() {
this.unsubscribe = NetInfo.addEventListener(this.onConnectionChange);
this.unsubscribe = NetInfo?.addEventListener(this.onConnectionChange);
}

componentWillUnmount() {
Expand Down Expand Up @@ -100,7 +105,7 @@ export default class ConnectionStatusBar extends PureBaseComponent {
}

async getInitialConnectionState() {
const isConnected = (await NetInfo.fetch()).isConnected;
const isConnected = (await NetInfo?.fetch()).isConnected;

this.setState({isConnected});
if (this.props.onConnectionChange) {
Expand Down
10 changes: 9 additions & 1 deletion src/components/dateTimePicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import moment from 'moment';
import React, {Component} from 'react';
import {StyleSheet} from 'react-native';
import RNDateTimePicker from '@react-native-community/datetimepicker';
import {DateTimePickerPackage as RNDateTimePicker} from '../../optionalDependencies';
import {Constants} from '../../helpers';
import {Colors} from '../../style';
import Assets from '../../assets';
Expand Down Expand Up @@ -115,6 +115,10 @@ class DateTimePicker extends Component {
prevValue: props.value,
value: props.value
};

if (!RNDateTimePicker) {
console.error(`RNUILib DateTimePicker component requires installing "@react-native-community/datetimepicker" dependency`);
}
}

static getDerivedStateFromProps(nextProps, prevState) {
Expand Down Expand Up @@ -226,6 +230,10 @@ class DateTimePicker extends Component {
}

renderDateTimePicker() {
if (!RNDateTimePicker) {
return null;
}

const {value, showExpandableOverlay} = this.state;
const {mode, minimumDate, maximumDate, locale, is24Hour, minuteInterval, timeZoneOffsetInMinutes} = this.props;

Expand Down
6 changes: 2 additions & 4 deletions src/components/modal/index.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
import _ from 'lodash';
import React, {Component} from 'react';
import {StyleSheet, Modal as RNModal, ModalProps as RNModalProps, TouchableWithoutFeedback, GestureResponderEvent} from 'react-native';
import {BlurViewPackage} from '../../optionalDependencies';
import {Constants} from '../../helpers';
import {asBaseComponent} from '../../commons/new';
import TopBar, {ModalTopBarProps} from './TopBar';
import View from '../../components/view';

let BlurView: any;
try {
BlurView = require('@react-native-community/blur').BlurView;
} catch (error) {} // warning in ctor, depends if user pass enableBlur
const BlurView = BlurViewPackage?.BlurView;

export {ModalTopBarProps};
export interface ModalProps extends RNModalProps {
Expand Down
6 changes: 6 additions & 0 deletions src/optionalDependencies/BlurViewPackage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
let BlurViewPackage: any;
try {
BlurViewPackage = require('@react-native-community/blur');
} catch (error) {}

export default BlurViewPackage;
6 changes: 6 additions & 0 deletions src/optionalDependencies/DateTimePickerPackage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
let DateTimePickerPackage: any;
try {
DateTimePickerPackage = require('@react-native-community/datetimepicker')?.default;
} catch (error) {}

export default DateTimePickerPackage;
6 changes: 6 additions & 0 deletions src/optionalDependencies/NetInfoPackage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
let NetInfoPackage: any;
try {
NetInfoPackage = require('@react-native-community/netinfo');
} catch (error) {}

export default NetInfoPackage;
10 changes: 10 additions & 0 deletions src/optionalDependencies/PickerPackage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
let PickerPackage: any, CommunityPickerPackage: any;
try {
PickerPackage = require('@react-native-picker/picker'); // New package
} catch (error) {
try {
CommunityPickerPackage = require('@react-native-community/picker'); // Deprecated package
} catch (error) {}
}

export {PickerPackage, CommunityPickerPackage};
4 changes: 4 additions & 0 deletions src/optionalDependencies/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export {default as DateTimePickerPackage} from './DateTimePickerPackage';
export {default as BlurViewPackage} from './BlurViewPackage';
export {default as NetInfoPackage} from './NetInfoPackage';
export {PickerPackage, CommunityPickerPackage} from './PickerPackage';