DialogDismissibleView - fix bug with delayed insets #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
added
the
Important for Next Release
ethanshar
approved these changes
Mar 2, 2021
Comment on lines
+66
to
+67
| const TOP_INSET = useRef<number>(Constants.isIphoneX ? Constants.getSafeAreaInsets().top : Constants.isIOS ? 20 : 0); | ||
| const BOTTOM_INSET = useRef<number>(Constants.isIphoneX ? Constants.getSafeAreaInsets().bottom : Constants.isIOS ? 20 : 0); |
There was a problem hiding this comment.
Looking at it now, it feels this kind of logic should be elsewhere, I guess in Constants. WDYT?
I can approve and we can refactor later of course
There was a problem hiding this comment.
I'm adding a ticket for this, it'll require some adjusting in both public and private, so I'd rather not mix it in this fix.
M-i-k-e-l
deleted the
fix/dialog-dismissible-view-problem-with-delayed-insets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DialogDismissibleView - fix bug with delayed insets (we have await in our private repo)
BTW, I think that code can probably be moved to public.
Changelog
DialogDismissibleView - fix bug with delayed insets