Fix Badge's size default prop #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
approved these changes
Mar 4, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Mar 8, 2021
…alue-change * master: Fix Badge's size default prop (#1212) Fix RadioGroup typings to extend our ViewProps and not React Native's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with Badge's defaultProps that contained a default value for
sizeprop.Because we have a default value, we declare the prop to not be optional.
But it causes issues in other places that depends on
BadgePropsfor example, an Avatar component has
badgeprop and its type isBadgeProps, but it doesn't know that size has a default value and it throws TS error that it is required (even though it's not)Changelog
Fix Badge's size default prop and make it optional