fix #1218 where carousel is not calculating children correctly #1219
Conversation
| @@ -1,50 +1,53 @@ | |||
| import React from 'react'; | |||
| import * as uut from '../CarouselPresenter'; | |||
|
|
|||
| describe('Carousel presenter', () => { | |||
| it('should getChildrenLength', () => { | |||
There was a problem hiding this comment.
you could argue this test is pointless now and can be deleted. It's just testing that React.Children.count works - which doesn't need to be tested.
There was a problem hiding this comment.
Why are you changing the tests from objects to tags?
There was a problem hiding this comment.
because {} is not a valid component in react. If you try and call React.children.count() with {} you'll get Objects are not valid as a React child (found: object with keys {}). If you meant to render a collection of children, use an array instead.
| export function getChildrenLength(props: CarouselProps): number { | ||
| const length = _.get(props, 'children.length') || 0; | ||
| return length; | ||
| type PropsWithChildren = CarouselProps & { children?: ReactNode } |
There was a problem hiding this comment.
'children' are not already part of CarouselProps?
There was a problem hiding this comment.
No - It is fine in the component because the class uses a generic which looks like readonly props: Readonly<P> & Readonly<{ children?: ReactNode }>;
Description
A fix for #1218
Changelog
Replaced
children.lengthwith Reacts children count helper.