-
Notifications
You must be signed in to change notification settings - Fork 734
Infra/color picker to ts #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra/color picker to ts #1235
Conversation
Any chance this can be split into smaller pieces? :shaking: |
There are 9 files for generated types that you don't need to review and another 2 are also related to types. If you still need smaller PRs I can do it when I'll get back from vacation... |
I'd really appreciate it if you could split it 🙏 |
@M-i-k-e-l All these components are being used by the ColorPicker component. How do you suggest I'll split the PR? |
You can start with a used component, since you can use a ts component in js component. |
…a/ColorPicker_to_TS
…-ui-lib into infra/ColorPicker_to_TS
use optional chaining instead of _.get() Co-authored-by: Ethan Sharabi <[email protected]>
…-ui-lib into infra/ColorPicker_to_TS
Description
Migrating to TypeScript:
Changelog
Migrating to TypeScript: