Skip to content

Infra/color picker to ts #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 1, 2021
Merged

Infra/color picker to ts #1235

merged 15 commits into from
May 1, 2021

Conversation

Inbal-Tish
Copy link
Collaborator

Description

Migrating to TypeScript:

  1. ColorPicker
  2. ColorSwatch
  3. ColorPalette
  4. ColorPickerDialog

Changelog

Migrating to TypeScript:

  1. ColorPicker
  2. ColorSwatch
  3. ColorPalette
  4. ColorPickerDialog

@Inbal-Tish Inbal-Tish requested a review from M-i-k-e-l March 22, 2021 13:03
@M-i-k-e-l
Copy link
Collaborator

Any chance this can be split into smaller pieces? :shaking:

@Inbal-Tish
Copy link
Collaborator Author

Any chance this can be split into smaller pieces? :shaking:

There are 9 files for generated types that you don't need to review and another 2 are also related to types. If you still need smaller PRs I can do it when I'll get back from vacation...

@M-i-k-e-l
Copy link
Collaborator

I'd really appreciate it if you could split it 🙏

@Inbal-Tish
Copy link
Collaborator Author

@M-i-k-e-l All these components are being used by the ColorPicker component. How do you suggest I'll split the PR?

@M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l All these components are being used by the ColorPicker component. How do you suggest I'll split the PR?

You can start with a used component, since you can use a ts component in js component.
Once the composed components are done the composing component can be refactored.

@ethanshar ethanshar requested review from ethanshar and removed request for M-i-k-e-l April 22, 2021 11:46
@ethanshar ethanshar assigned ethanshar and unassigned M-i-k-e-l Apr 22, 2021
@Inbal-Tish Inbal-Tish requested a review from ethanshar April 25, 2021 09:43
@ethanshar ethanshar merged commit d4a21e1 into master May 1, 2021
@Inbal-Tish Inbal-Tish deleted the infra/ColorPicker_to_TS branch May 23, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants