Avatar - add name with initials and backgroundColor specific to that name #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Apr 5, 2021
| @@ -43,6 +43,19 @@ export function getInitials(name: string) { | |||
| return _.toUpper(initials); | |||
| } | |||
|
|
|||
| export function getBackgroundColor(name?: string, | |||
There was a problem hiding this comment.
consider adding few simple tests to cover the new functionalities
There was a problem hiding this comment.
Done (found a bug!)
There was a problem hiding this comment.
The power of testings (:
ethanshar
reviewed
Apr 8, 2021
| * Hash the name (or label) to get a color, so each name will have a specific color. | ||
| * Default is false. | ||
| */ | ||
| useAutoColorsConfig?: boolean; |
There was a problem hiding this comment.
useAutoColorsConfig sounds like the user must pass it. I think useAutoColors is better
Suggested change
| useAutoColorsConfig?: boolean; | |
| useAutoColors?: boolean; |
| @@ -43,6 +43,19 @@ export function getInitials(name: string) { | |||
| return _.toUpper(initials); | |||
| } | |||
|
|
|||
| export function getBackgroundColor(name?: string, | |||
There was a problem hiding this comment.
The power of testings (:
|
Looks great! |
ethanshar
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avatar - add name with initials and backgroundColor specific to that name (i.e. hash)
Changelog
Avatar - add name with initials and backgroundColor specific to that name (i.e. hash)