Configure module-resolver plugin #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Apr 1, 2021
| @@ -1,28 +1,5 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Don't we need the compilerOptoins anymore?
There was a problem hiding this comment.
Nope,
You can see that I now extends our base tsconfig.json file that already contains the relevant compilerOptions
"extends": "./tsconfig",
lidord-wix
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
POC for using
babel-plugin-module-resolverpackage.It allows us to create aliases to long relative paths (eg,
../../style,../../helpers, etc..)Instead we can just import from our predefined aliases (eg.
style,helpers, etc...)In this PR I just made couple of changes in Button code to test the usage of this plugin.
I'd like to give it some time and see that it integrates well in private uilib and in One App.
If we won't have any complains or issues I'll fully integrate this plugin
Changelog
Use internally
babel-plugin-module-resolverfor resolving relative paths