Fix callback props typings in various components #1250
Conversation
| @@ -30,7 +30,7 @@ export interface TouchableOpacityProps extends Omit<RNTouchableOpacityProps, 'st | |||
| */ | |||
| customValue?: any; | |||
| style?: StyleProp<ViewStyle> | Animated.AnimatedProps<StyleProp<ViewStyle>>; | |||
| onPress?: (props: TouchableOpacityProps | any) => void; | |||
| onPress?: (props?: TouchableOpacityProps | any) => void; | |||
There was a problem hiding this comment.
What the reason we need | any here?
There was a problem hiding this comment.
Hmm good point.
It was here before, but it might be irrelevant..
ill try to remove it and see if it affect us
There was a problem hiding this comment.
Ok, there was a reason for the any type.
In TouchableOpacity we allow to pass a prop called customValue which can be anything you want to pass and get back in the onPress callback.
Because customValue can be anything, we have to support any type in the onPress callback, cause we can't tell what it'll be
There was a problem hiding this comment.
Yeah I see now. make sense :)
| @@ -83,7 +83,7 @@ declare const _default: React.ComponentClass<ViewProps & TouchableOpacityProps & | |||
| /** | |||
| * action for when pressing the card | |||
| */ | |||
| onPress?: (() => void) | undefined; | |||
| onPress?: ((props?: any) => void) | undefined; | |||
There was a problem hiding this comment.
Is typescript still make us use | undefined although onPress is an optional?
(We don't use it in onCancel and onDone for example)
There was a problem hiding this comment.
You are looking at the generatedTypes file, this is how it generates the d.ts files apparently.
The source code doesn't have it
Description
Fix callback props typings in components like: TouchableOpacity, Card and Modal.TopBar
Changelog
Fix callback props typings in components like: TouchableOpacity, Card and Modal.TopBar