Picker - filter children (for long lists with search) #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
May 2, 2021
Comment on lines
+276
to
+294
| getFilteredChildren = memoize((children, searchValue) => { | ||
| const {getItemLabel: getItemLabelPicker} = this.props; | ||
| return _.filter(children, child => { | ||
| const {label, value, getItemLabel} = child.props; | ||
| const itemLabel = getItemLabelPresenter(label, value, getItemLabel || getItemLabelPicker); | ||
| return !shouldFilterOut(searchValue, itemLabel); | ||
| }); | ||
| }); | ||
|
|
||
| get children() { | ||
| const {searchValue} = this.state; | ||
| const {children, showSearch} = this.props; | ||
| if (showSearch && !_.isEmpty(searchValue)) { | ||
| return this.getFilteredChildren(children, searchValue); | ||
| } | ||
|
|
||
| return children; | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks good! we should remove the search logic we have in PickerItem code since this one covers it.
ethanshar
reviewed
May 4, 2021
| @@ -80,10 +80,6 @@ const PickerItem = props => { | |||
| ); | |||
| }; | |||
|
|
|||
| if (context.showSearch && shouldFilterOut(context.searchValue, itemLabel)) { | |||
There was a problem hiding this comment.
You can also stop passing showSearch and searchValue in the context provided by the Picker
ethanshar
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker - filter children (for long lists with search).
I think this solved the issue, but it has some code duplication with the
Picker.Item, do you think it can be removed from the item?Should resolve #1244
Changelog
Picker - filter children (for long lists with search)