Feat/add label to wheelPicker #1259
Conversation
src/incubator/WheelPicker/index.tsx
Outdated
| /> | ||
| center | ||
| > | ||
| <Text marginL-80 text80M {...rightLabelProps} color={activeTextColor} style={rightLabelStyle}> |
There was a problem hiding this comment.
Maybe we should change the function name / move the label out, since now it's not rendering only the separators
src/incubator/WheelPicker/index.tsx
Outdated
| /** | ||
| * Additional label on the right of the item text | ||
| */ | ||
| rightLabel?: string; |
There was a problem hiding this comment.
Is there going to be another label? if not, maybe we should call it label
| @@ -28,6 +29,18 @@ export interface WheelPickerProps { | |||
| * Row text style | |||
| */ | |||
| textStyle?: TextStyle; | |||
| /** | |||
There was a problem hiding this comment.
I'm not sure we supposed to do any changes in this files (it's under generatedType)
There was a problem hiding this comment.
I didn't, It's automatic :)
src/incubator/WheelPicker/index.tsx
Outdated
| @@ -143,7 +159,7 @@ const WheelPicker = React.memo( | |||
| [itemHeight] | |||
| ); | |||
|
|
|||
| const separators = () => { | |||
| const renderCentralFrame = () => { | |||
There was a problem hiding this comment.
Sorry to nudge you 😬
renderSeparatorsAndLabel or something, make more sense - at least to me, didn't get at first what a central frame is..
There was a problem hiding this comment.
Done.
I also changed the screen a bit to make it fit for small screens.
verified on Android as well
Description
Add right label to the wheelPicker selected value
Changelog
Add right label to the wheelPicker selected value