Feat/Picker selectionLimit prop #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Apr 27, 2021
| const accessibilityProps = { | ||
| accessibilityState: isSelected ? {selected: true} : undefined, | ||
| accessibilityHint: 'Double click to select this suggestion', | ||
| ...Modifiers.extractAccessibilityProps(props) | ||
| }; | ||
|
|
||
| const isItemDisabled = useMemo(() => { | ||
| return disabled || (!isSelected && context.selectionLimit && context.selectionLimit === selectedCounter); | ||
| }, [selectedCounter]); |
There was a problem hiding this comment.
Notice you use a simple variable as a dependency in this useMemo.
Each time the component will render, selectedCounter will be recreated and will invoke the useMemo
Overall it's not that dramatic in this case, but better do it right.
I'd move selectedCounter into the useMemo method and include in the dependencies array values from props/context/state.
ethanshar
added
the
Important for Next Release
ethanshar
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add selectionLimit prop to the Picker component to support limiting the number of the selected items.
Jira 1702
Changelog
Add selectionLimit prop to the Picker component to support limiting the number of the selected items.