Feat/slider orientation support #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Apr 27, 2021
| this[layoutName] = size; | ||
|
|
||
| if (this.containerSize && this.thumbSize && this.trackSize) { | ||
| // console.warn('post return'); |
There was a problem hiding this comment.
You can delete this console
Inbal-Tish
reviewed
Apr 27, 2021
| @@ -41,7 +41,7 @@ export default class SliderScreen extends Component { | |||
| <Image assetName={'megaphone'} style={styles.image}/> | |||
| <Slider | |||
| onValueChange={this.onSliderValueChange} | |||
| value={INITIAL_VALUE} | |||
| value={this.state.sliderValue} | |||
There was a problem hiding this comment.
Why do we need to keep updating the value by state here? The 'value' prop is for the initial value, once you update it the Slider takes care of the value and uses 'onValueChange' to update the user with the new value. When we update it back to the Slider we'll have an extra render on any value change which can affect performance.
ethanshar
added
the
Important for Next Release
Inbal-Tish
reviewed
May 19, 2021
| const range = this.getRange(); | ||
| const relativeValue = maximumValue > 0 ? minimumValue - v : maximumValue - v; // for negatives in min value | ||
| const relativeValue = minimumValue - v; |
There was a problem hiding this comment.
Is there a way to test this part. In unit tests or e2e?
Inbal-Tish
approved these changes
May 19, 2021
|
@mendyEdri I approved the PR. Merge when you want. I just wondering if it's not better to add tests first to make sure we didn't break any one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting Slider react and recalculate when orientation is changed
Changelog
Add support to Slider component to react to orientation changes