Skip to content

Incubator.TextField fixes #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2021
Merged

Incubator.TextField fixes #1288

merged 5 commits into from
May 6, 2021

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented May 4, 2021 •
edited
Loading

Description

These are some issues I found when I tried to match our TextField guidelines with the new implementation.

  • Fix issue with FloatingPlaceholderColor ignore default preset
  • support placeholderTextColor with color object preset
  • Support floating placeholder behavior like floatOnFocus
  • Fix overlapping of floatingPlaceholder with top validation message
  • support a way to set underline color with a color object preset

Changelog

Various fixes in Incubator.TextFied: Fix floatingPlaceholder issues, support passing a function to field style ((fieldContext) => ViewStyle)

@ethanshar ethanshar changed the title Fix issue with FloatingPlaceholderColor ignore default preset Incubator.TextField fixes May 4, 2021
@ethanshar ethanshar requested a review from lidord-wix May 5, 2021 07:51
@lidord-wix lidord-wix merged commit d6f9670 into master May 6, 2021
@ethanshar ethanshar deleted the fix/IncubtorTextField branch November 30, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @lidord-wix