Fix various typing issues #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
May 9, 2021
| @@ -39,6 +39,7 @@ export type TextProps = RNTextProps & TypographyModifiers & ColorsModifiers & Ma | |||
| */ | |||
| animated?: boolean; | |||
| textAlign?: string; | |||
| style?: StyleProp<TextStyle | Animated.AnimatedProps<TextStyle>>; | |||
There was a problem hiding this comment.
You need to Omit<RNTextProps, 'style'> in TextProps
There was a problem hiding this comment.
Yes, weirdly it didn't throw an error on that, anyway fixed it.
There was a problem hiding this comment.
We should move more screens to tsx (found it there)
| @@ -44,7 +44,7 @@ export type CardSectionProps = ViewProps & { | |||
| /** | |||
| * Other image props that will be passed to the image | |||
| */ | |||
| imageProps?: ImageProps; | |||
| imageProps?: Partial<ImageProps>; | |||
There was a problem hiding this comment.
This: imageProps?: Omit<ImageProps, 'source' | 'style'>; feels a bit more accurate, WDYT?
There was a problem hiding this comment.
Not really, technically you can also pass source in imageProps and it will work
There was a problem hiding this comment.
I know, but I'm not sure it's intentional, approving
M-i-k-e-l
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix various typing issues
Changelog
Fix Button iconSource type, Card.Section ImageProps to not require source and Text to support animated text style