Support auto height layout for vertical carousel #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
May 9, 2021
|
|
||
| <View centerH flex marginT-s3> | ||
| <Text h3 marginB-s2> | ||
| iOS Widgets Carousel |
There was a problem hiding this comment.
Why is it called this way?
There was a problem hiding this comment.
Hmmm good question..
Cause it's very similar to the layout of widgets in iOS 😬
I didn't have a better name..
I can call it auto height layout or something like that, but it felt less appealing (:
M-i-k-e-l
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix support for auto height layout for vertical carousel pages
Changelog
Fix support for auto height layout for vertical carousel pages