Fix/ WheelPicker onChange in Android #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
May 13, 2021
There was a problem hiding this comment.
@lidord-wix
I didn't dive into the code yet, but I noticed an issue with this fix.
See that now on Android, when selecting a different value using a click, it doesn't scroll to it, but immediately change the value.
Ohh I see.. |
ethanshar
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onMomentumScrollEndnot being called in Android - facebook/react-native#26661Add a call for the
onChange()callback manually.Changelog
Fix inconsistent between iOS and Android by calling the
onChange()function manually