Skip to content

Feat/ update gradient for TOP and BOTTOM overlays #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2021
Merged

Feat/ update gradient for TOP and BOTTOM overlays #1311

merged 2 commits into from
May 30, 2021

Conversation

lidord-wix
Copy link
Contributor

Description

Update gradient for TOP and BOTTOM Image overlays
Ticket 1743

Changelog

Update gradient for TOP and BOTTOM Image overlays

@lidord-wix lidord-wix requested a review from ethanshar May 18, 2021 09:13
@ethanshar ethanshar requested review from M-i-k-e-l and removed request for ethanshar May 18, 2021 09:28
@ethanshar ethanshar assigned M-i-k-e-l and unassigned ethanshar May 18, 2021
@M-i-k-e-l
Copy link
Collaborator

It does not look like there's a difference between the old and the new gradient, add the text ("Show Overlay Content") and you'll see it's not similar to the design.

@lidord-wix
Copy link
Contributor Author

It does not look like there's a difference between the old and the new gradient, add the text ("Show Overlay Content") and you'll see it's not similar to the design.

There's a difference, you can see it when you toggle from vertical to top (or to bottom).
And for me, it looks like in the guidelines - you can find here 2 examples where I changed the text:
image
image

@M-i-k-e-l M-i-k-e-l merged commit 944f57f into master May 30, 2021
@lidord-wix lidord-wix deleted the feat/upadte_gradientOverlay branch May 31, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidord-wix @M-i-k-e-l @ethanshar