Skip to content

Add testID to wheel picker list #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2021
Merged

Conversation

ethanshar
Copy link
Collaborator

Description

Add testID to wheel picker list

Changelog

Add testID to wheel picker list (${testID}.list)

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should modify the testID of the items to be:
testID={'${testID}.item'}

@ethanshar
Copy link
Collaborator Author

I think we should modify the testID of the items to be:
testID={'${testID}.item'}

Done ✅

@lidord-wix lidord-wix merged commit 5aadf72 into master May 20, 2021
ethanshar added a commit that referenced this pull request May 20, 2021
* Add testID to wheel picker list

* Update wheel picker items testID
@ethanshar ethanshar deleted the feat/WheelPickerListTestID branch November 30, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants