Skip to content

Support checking for required props in a component #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

Add support to our component-prop-deprecation rule to verify required props

Changelog

Add support to our component-prop-deprecation rule to verify required props

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, but honestly, I think it should be a different rule since it's not really a prop deprecation.
Ideally, the component-prop-deprecation.json (in private) shouldn't contain anything, but the JSON file of this rule should contain props permanently..

@ethanshar
Copy link
Collaborator Author

The code looks great, but honestly, I think it should be a different rule since it's not really a prop deprecation.
Ideally, the component-prop-deprecation.json (in private) shouldn't contain anything, but the JSON file of this rule should contain props permanently..

After what we discussed you still think we need to have this rule separated?

@lidord-wix
Copy link
Contributor

The code looks great, but honestly, I think it should be a different rule since it's not really a prop deprecation.
Ideally, the component-prop-deprecation.json (in private) shouldn't contain anything, but the JSON file of this rule should contain props permanently..

After what we discussed you still think we need to have this rule separated?

Nope, approving :)

@lidord-wix lidord-wix merged commit 1a8ca6a into master May 30, 2021
@ethanshar ethanshar deleted the infra/lintRule_requiredProps branch November 30, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants