Refactor TabController to use Reanimated v2 API #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
changed the title
ethanshar
added
the
Important for Next Release
M-i-k-e-l
reviewed
Jun 21, 2021
M-i-k-e-l
reviewed
Jun 24, 2021
Comment on lines
+120
to
+121
| const sharedLabelStyle = useSharedValue(JSON.parse(JSON.stringify(labelStyle))); | ||
| const sharedSelectedLabelStyle = useSharedValue(JSON.parse(JSON.stringify(selectedLabelStyle))); |
There was a problem hiding this comment.
Looks like this can be solved using only:
const sharedLabelStyle = useSharedValue(labelStyle);
const sharedSelectedLabelStyle = useSharedValue(selectedLabelStyle);
and in animatedLabelStyle returning:
return (isActive ? sharedSelectedLabelStyle.value : sharedLabelStyle.value) || {};
There was a problem hiding this comment.
The issue this solves wasn't exposed cause some code is commented out in the example screen
I pushed a code the expose the bug -> ff8c461
M-i-k-e-l
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<Code/>blocks, now we're using shared values and animated styles.Changelog
Reimplement
TabControllercomponent with reanimated v2 API (currently exported as TabController2)