Typescript/log service #1337
Merged
Typescript/log service #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Jun 3, 2021
lidord-wix
reviewed
Jun 6, 2021
Comment on lines
1
to
11
| declare function warn(message: string): void; | ||
| declare function deprecationWarn({ component, oldProp, newProp }: { | ||
| component: string; | ||
| oldProp: string; | ||
| newProp?: string; | ||
| }): void; | ||
| declare const _default: { | ||
| warn: typeof warn; | ||
| deprecationWarn: typeof deprecationWarn; | ||
| }; | ||
| export default _default; |
There was a problem hiding this comment.
This file is actually required..
run npm run build:dev and you'll see this file added :)
lidord-wix
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate LogService to typescript.
Changelog
Migrate LogService to typescript.