Typescript/feature highlight #1338
Conversation
mendyEdri
requested review from
M-i-k-e-l and
Inbal-Tish
and removed request for
M-i-k-e-l
| */ | ||
| pageControlProps: PropTypes.shape(PageControl.propTypes) | ||
| }; | ||
| static propTypes = {}; |
There was a problem hiding this comment.
Why did you leave the propTypes static object?
| @@ -298,7 +332,7 @@ class FeatureHighlight extends BaseComponent { | |||
| titleStyle | |||
| ]} | |||
| numberOfLines={titleNumberOfLines} | |||
| pointerEvents="none" | |||
| pointerEvents | |||
There was a problem hiding this comment.
I don't understand the meaning of this change. pointerEvets prop is not a boolean so why did you drop the value ("none")?
There was a problem hiding this comment.
It becomes boolean from out modifiers, and some how react-native haven't export this prop with a type,
so I changed it back and added @ts-expect-error
| @@ -219,8 +252,8 @@ class FeatureHighlight extends BaseComponent { | |||
| } | |||
|
|
|||
| getContentPosition() { | |||
| const {highlightFrame, minimumRectSize, innerPadding} = this.props; | |||
| const {top, height} = this.targetPosition; | |||
| const {highlightFrame, minimumRectSize = {height: 0}, innerPadding = 0} = this.props; | |||
There was a problem hiding this comment.
minimumRectSize is of type ReactSize, is setting only the height as default enough?
There was a problem hiding this comment.
Yes, since it's only used the height in line 262
There was a problem hiding this comment.
Yes, I know. I just thought it might give you a type error...
|
@mendyEdri Resolve conflicts and merge please. |
Description
Migrate
FeatureHighlightcomponent into typescript.Changelog
Migrate
FeatureHighlightcomponent into typescript.