Skip to content

DateTimePicker - Implement renderInput prop #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Amurmurmur
Copy link

The renderInput prop was missing, it was mentioned in the documentation however wasnt used in the code.

Description

The renderInput prop wasnt used in the codebase for the DateTimePicker, however it was mentioned in the documentation therefore it wasn't able to let the user to provide with their own custom input component instead of a default TextField

Changelog

Abillity to use renderInput prop with the DateTimePicker component that was missing.

The renderInput prop was missing, it was mentioned in the documentation however wasnt used in the code.
@Amurmurmur Amurmurmur changed the title Use renderInput prop as per documentation DateTimePicker - Use renderInput prop as per documentation Jun 9, 2021
@Amurmurmur Amurmurmur changed the title DateTimePicker - Use renderInput prop as per documentation DateTimePicker - Implement renderInput prop Jun 9, 2021
@ethanshar
Copy link
Collaborator

Hi @Amurmurmur
We fixed this issue with this PR #1386

Closing this.

@ethanshar ethanshar closed this Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants