Unify some code in the native picker dialog implementation #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Jun 20, 2021
| return renderNativePicker(this.props); | ||
| } | ||
| return ( | ||
| <WheelPicker selectedValue={selectedValue} onChange={onValueChange} {...wheelPickerProps} testID={`${testID}.wheelPicker`}> |
There was a problem hiding this comment.
You don't need the selectedValue, onValueChange, and wheelPickerProps in the propTypes anymore :)
| return renderNativePicker(this.props); | ||
| } | ||
| return ( | ||
| <WheelPicker style={pickerStyle} selectedValue={selectedValue} onChange={onValueChange} testID={`${testID}.wheelPicker`}> |
There was a problem hiding this comment.
Same here, you don't need the selectedValue and onValueChange props
lidord-wix
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unify the code that renders the inner WheelPicker inside the the dialog of the Picker (when passing
useNativePicker).We have a different implementation of the dialog per each platform but the content should be the same.
This PR is a preparation for JIRA WOAUILIB-1843
Changelog
Unify internal code of native picker (wheel picker)