Skip to content

Skeleton View #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 15, 2021
Merged

Skeleton View #1378

merged 11 commits into from
Jul 15, 2021

Conversation

kochavi-daniel
Copy link
Contributor

Description

Added SkeletonView

Changelog

Added Skeleton View

@kochavi-daniel kochavi-daniel requested a review from ethanshar June 29, 2021 16:11
@ethanshar ethanshar requested review from M-i-k-e-l and removed request for ethanshar June 30, 2021 06:34
@ethanshar
Copy link
Collaborator

@M-i-k-e-l
Daniel as part of his guild week migrated our SkeletonView component to public.
Can you please review

M-i-k-e-l
M-i-k-e-l reviewed Jul 5, 2021
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kochavi-daniel,
Thanks for your contribution, there are some comments, please let me know if you don't have the capacity to fix them all.

@kochavi-daniel
Copy link
Contributor Author

Hi @kochavi-daniel,
Thanks for your contribution, there are some comments, please let me know if you don't have the capacity to fix them all.

Thank you for your in depth review, I'll get to it this Thursday.

@M-i-k-e-l
Copy link
Collaborator

Thanks!

Only three more things I can see:

  1. Formatting the files, maybe you don't have the extensions we have.
  2. Running npm run build:dev to recreate the .d files.
  3. The screen is missing a key in the ListItem.

@M-i-k-e-l M-i-k-e-l enabled auto-merge (squash) July 15, 2021 13:29
@M-i-k-e-l M-i-k-e-l merged commit 0efb8bb into master Jul 15, 2021
@M-i-k-e-l M-i-k-e-l deleted the daniel/skeleton_view branch October 4, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kochavi-daniel @ethanshar @M-i-k-e-l