Skip to content

WheelPicker - fix warning about getNode #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2021
Merged

WheelPicker - fix warning about getNode #1403

merged 3 commits into from
Jul 14, 2021

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

WheelPicker - fix warning about getNode

Changelog

WheelPicker - fix warning about getNode

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar July 13, 2021 13:58
@ethanshar ethanshar requested a review from lidord-wix July 14, 2021 10:40
@ethanshar ethanshar assigned lidord-wix and unassigned ethanshar Jul 14, 2021
@ethanshar ethanshar removed their request for review July 14, 2021 10:40
lidord-wix
lidord-wix reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I suggest changing the all ts-ignore to ts-expect-error :)

@lidord-wix lidord-wix merged commit d377226 into master Jul 14, 2021
@M-i-k-e-l M-i-k-e-l deleted the fix/wheel-picker-fix-warning-regarding-get-node branch October 4, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M-i-k-e-l @lidord-wix @ethanshar