Skip to content

Fix issue with TabController not handling dynamic items size #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2021
Merged

Fix issue with TabController not handling dynamic items size #1416

merged 3 commits into from
Jul 20, 2021

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented Jul 19, 2021 •
edited
Loading

Description

This PR fix two issues with new implementation of TabController (2)

  • Fix issue with "ignored" tab item not being ignored
  • Fix issue when items size change, the TabBar didn't rebuild itself with the new items
  • Fix backward compatibility for passing items prop directly to TabController.TabBar (instead of TabController)

Changelog

Fix TabController2 issue with rebuilding TabBar items when their count changes

@ethanshar ethanshar requested a review from lidord-wix July 19, 2021 14:31
@lidord-wix lidord-wix merged commit c2c5b91 into master Jul 20, 2021
@ethanshar ethanshar deleted the fix/TabController_dynamicItems branch April 18, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @lidord-wix