Skip to content

Infra/no import rule multiple #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Conversation

mendyEdri
Copy link
Contributor

Description

Add support for multiple rules in no-direct-import.

Changelog

Support having multiple eslint rules passed as array in no-direct-import rule.

@mendyEdri mendyEdri requested a review from ethanshar July 21, 2021 15:54
@ethanshar ethanshar requested review from lidord-wix and removed request for ethanshar July 22, 2021 06:56
@ethanshar ethanshar assigned lidord-wix and unassigned ethanshar Jul 22, 2021
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look really good, I left one small comment :)

@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-uilib",
"version": "2.0.9",
"version": "2.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should bump from 2.0.9 to 2.1.0 or to 2.0.10.. do you know if there's any logic for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base on Semantic Versioning.
("MINOR version when you add functionality in a backwards compatible manner")

@mendyEdri mendyEdri requested a review from lidord-wix August 3, 2021 15:55
@lidord-wix lidord-wix merged commit 0ca0556 into master Aug 3, 2021
@mendyEdri mendyEdri deleted the infra/no-import-rule-multiple branch December 27, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants