Docs/fix broken urls #1427
Merged
Docs/fix broken urls #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Jul 25, 2021
| @@ -24,7 +24,6 @@ const GUTTER_SPACING = 8; | |||
| * @gif: https://camo.githubusercontent.com/9c2671024f60566b980638ea01b517f6fb509d0b/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f336f45686e374a79685431566658746963452f67697068792e676966 | |||
| * @example: https://github.com/wix/react-native-ui-lib/blob/master/demo/src/screens/componentScreens/ChipsInputScreen.js | |||
| * @extends: TextField | |||
| * @extendsLink: https://github.com/wix/react-native-ui-lib/blob/master/src/components/inputs/TextField.js | |||
There was a problem hiding this comment.
I see you've removed some links instead of replacing them, why?
There was a problem hiding this comment.
Cause our docs internally knows to refer to other components by their name.
In this case, TagsInput is based on our TextField component, so the name is enough.
The TextField component will have an external link (@extendsLink) that directs to RN's TextInput component
M-i-k-e-l
approved these changes
Jul 26, 2021
|
Approved, there's a conflict in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix broken link in our docs
Changelog
Fix broken link in our docs