Skip to content

Add support to initialValue in WheelPicker #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2021
Merged

Add support to initialValue in WheelPicker #1436

merged 4 commits into from
Aug 5, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

I added a new prop initialValue to Incubator.WheelPicker.
initialValue doesn't work together with selectedValue prop
The first (initialValue) makes the picker uncontrolled in a way the user doesn't need to pass it on every change.
The second (selectedValue) is completely controlled

Notice that passing a new initialValue will reset the value and index of the picker.

Changelog

Add initialValue prop to Incubator.WheelPicker

M-i-k-e-l
M-i-k-e-l reviewed Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to support both options or is this a transition?

@ethanshar ethanshar requested a review from M-i-k-e-l August 3, 2021 06:10
@ethanshar
Copy link
Collaborator Author

Are we planning to support both options or is this a transition?

Haven't decided yet. For now I think we'll keep both and see how it goes..

@M-i-k-e-l M-i-k-e-l merged commit 1e1309a into master Aug 5, 2021
@ethanshar ethanshar deleted the feat/WheelPicker_initialValue branch November 30, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

@lidord-wix lidord-wix Awaiting requested review from lidord-wix

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l