Fix/ drawer RTL bug #1446
Merged
Fix/ drawer RTL bug #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Aug 5, 2021
| : undefined; | ||
| this.leftRender = Constants.isRTL | ||
| ? props.rightItems && this.renderRightActions | ||
| : props.leftItem && this.renderLeftActions; |
There was a problem hiding this comment.
Why not check if leftItem exists in the renderLeftActions method? (and the same for the rightItems...)
There was a problem hiding this comment.
It actually doesn't work.. the value of this.leftRender should be undefined and not () => undefined if the items don't exist.
I can write the methods that way, but I'm not sure if it makes it more clear:
private renderLeftActions = this.props.leftItem
? (progress: Animated.Value /* , dragX: Animated.Value */) => {
const {leftItem} = this.props;
const leftItems = leftItem ? [leftItem] : undefined;
return this.renderActions(leftItems, progress /* , dragX */);
}
: undefined;
ethanshar
added
the
Important for Next Release
ethanshar
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with swiping drawer in RTL mode when there are items only on one side
issue - WOAUILIB-1965
Changelog
Fix RTL bug in drawer